diff options
| author | Coly Li <i@coly.li> | 2011-02-24 12:51:59 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2011-02-24 12:51:59 -0500 |
| commit | 84b775a354f640736176b5d966408fc5d5da6665 (patch) | |
| tree | c7b26ce41a9234e48bfc74514b960b9b38b40c5d /fs/ext4 | |
| parent | ea6633369458992241599c9d9ebadffaeddec164 (diff) | |
| download | linux-3.10-84b775a354f640736176b5d966408fc5d5da6665.tar.gz linux-3.10-84b775a354f640736176b5d966408fc5d5da6665.tar.bz2 linux-3.10-84b775a354f640736176b5d966408fc5d5da6665.zip | |
ext4: code cleanup in mb_find_buddy()
Current code calculate max no matter whether order is zero, it's
unnecessary. This cleanup patch sets max to "1 << (e4b->bd_blkbits
+ 3)" only when order == 0.
Signed-off-by: Coly Li <bosong.ly@taobao.com>
Cc: Alex Tomas <alex@clusterfs.com>
Cc: Theodore Tso <tytso@google.com>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/mballoc.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index ae4d7f5edbb..1791dd4207d 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -432,9 +432,10 @@ static void *mb_find_buddy(struct ext4_buddy *e4b, int order, int *max) } /* at order 0 we see each particular block */ - *max = 1 << (e4b->bd_blkbits + 3); - if (order == 0) + if (order == 0) { + *max = 1 << (e4b->bd_blkbits + 3); return EXT4_MB_BITMAP(e4b); + } bb = EXT4_MB_BUDDY(e4b) + EXT4_SB(e4b->bd_sb)->s_mb_offsets[order]; *max = EXT4_SB(e4b->bd_sb)->s_mb_maxs[order]; |