diff options
author | Jeff Moyer <jmoyer@redhat.com> | 2012-02-20 17:59:24 -0500 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2012-02-20 17:59:24 -0500 |
commit | 266991b13890049ee1a6bb95b9817f06339ee3d7 (patch) | |
tree | 55c4f0e3c0b978e563ced079002bcf7ea60d9767 /fs/ext4/page-io.c | |
parent | d4dc462f556afe510d58d3b12b3d66c2cabff539 (diff) | |
download | linux-3.10-266991b13890049ee1a6bb95b9817f06339ee3d7.tar.gz linux-3.10-266991b13890049ee1a6bb95b9817f06339ee3d7.tar.bz2 linux-3.10-266991b13890049ee1a6bb95b9817f06339ee3d7.zip |
ext4: fix race between unwritten extent conversion and truncate
The following comment in ext4_end_io_dio caught my attention:
/* XXX: probably should move into the real I/O completion handler */
inode_dio_done(inode);
The truncate code takes i_mutex, then calls inode_dio_wait. Because the
ext4 code path above will end up dropping the mutex before it is
reacquired by the worker thread that does the extent conversion, it
seems to me that the truncate can happen out of order. Jan Kara
mentioned that this might result in error messages in the system logs,
but that should be the extent of the "damage."
The fix is pretty straight-forward: don't call inode_dio_done until the
extent conversion is complete.
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/ext4/page-io.c')
-rw-r--r-- | fs/ext4/page-io.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 47585189651..9e1b8eb1e7a 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -110,6 +110,8 @@ int ext4_end_io_nolock(ext4_io_end_t *io) if (io->iocb) aio_complete(io->iocb, io->result, 0); + if (io->flag & EXT4_IO_END_DIRECT) + inode_dio_done(inode); /* Wake up anyone waiting on unwritten extent conversion */ if (atomic_dec_and_test(&EXT4_I(inode)->i_aiodio_unwritten)) wake_up_all(ext4_ioend_wq(io->inode)); |