summaryrefslogtreecommitdiff
path: root/fs/ext2
diff options
context:
space:
mode:
authorNeil Horman <nhorman@tuxdriver.com>2010-03-05 13:44:16 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2010-03-06 11:26:46 -0800
commit76595f79d76fbe6267a51b3a866a028d150f06d4 (patch)
treeeff36adfb339f8cb57b07fd9f09d37d982aa354e /fs/ext2
parent5c99cbf49a6e1a1efd25b11f4604c65c455e1612 (diff)
downloadlinux-3.10-76595f79d76fbe6267a51b3a866a028d150f06d4.tar.gz
linux-3.10-76595f79d76fbe6267a51b3a866a028d150f06d4.tar.bz2
linux-3.10-76595f79d76fbe6267a51b3a866a028d150f06d4.zip
coredump: suppress uid comparison test if core output files are pipes
Modify uid check in do_coredump so as to not apply it in the case of pipes. This just got noticed in testing. The end of do_coredump validates the uid of the inode for the created file against the uid of the crashing process to ensure that no one can pre-create a core file with different ownership and grab the information contained in the core when they shouldn' tbe able to. This causes failures when using pipes for a core dumps if the crashing process is not root, which is the uid of the pipe when it is created. The fix is simple. Since the check for matching uid's isn't relevant for pipes (a process can't create a pipe that the uermodehelper code will open anyway), we can just just skip it in the event ispipe is non-zero Reverts a pipe-affecting change which was accidentally made in : commit c46f739dd39db3b07ab5deb4e3ec81e1c04a91af : Author: Ingo Molnar <mingo@elte.hu> : AuthorDate: Wed Nov 28 13:59:18 2007 +0100 : Commit: Linus Torvalds <torvalds@woody.linux-foundation.org> : CommitDate: Wed Nov 28 10:58:01 2007 -0800 : : vfs: coredumping fix Signed-off-by: Neil Horman <nhorman@tuxdriver.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext2')
0 files changed, 0 insertions, 0 deletions