diff options
author | Christoph Hellwig <hch@infradead.org> | 2007-07-17 04:04:29 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-17 10:23:06 -0700 |
commit | 5ca29607331fe37980dc3b488793ef8b1409b722 (patch) | |
tree | cf4e5ad786aeebc8d82d1b867ab3d91d0cb4b824 /fs/efs/super.c | |
parent | a569425512253992cc64ebf8b6d00a62f986db3e (diff) | |
download | linux-3.10-5ca29607331fe37980dc3b488793ef8b1409b722.tar.gz linux-3.10-5ca29607331fe37980dc3b488793ef8b1409b722.tar.bz2 linux-3.10-5ca29607331fe37980dc3b488793ef8b1409b722.zip |
knfsd: exportfs: remove iget abuse
When the exportfs interface was added the expectation was that filesystems
provide an operation to convert from a file handle to an inode/dentry, but it
kept a backwards compat option that still calls into iget.
Calling into iget from non-filesystem code is very bad, because it gives too
little information to filesystem, and simply crashes if the filesystem doesn't
implement the ->read_inode routine.
Fortunately there are only two filesystems left using this fallback: efs and
jfs. This patch moves a copy of export_iget to each of those to implement the
get_dentry method.
While this is a temporary increase of lines of code in the kernel it allows
for a much cleaner interface and important code restructuring in later
patches.
[akpm@linux-foundation.org: add jfs_get_inode_flags() declaration]
Signed-off-by: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/efs/super.c')
-rw-r--r-- | fs/efs/super.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/efs/super.c b/fs/efs/super.c index 67338d622f5..d360c81f3a7 100644 --- a/fs/efs/super.c +++ b/fs/efs/super.c @@ -114,6 +114,7 @@ static const struct super_operations efs_superblock_operations = { }; static struct export_operations efs_export_ops = { + .get_dentry = efs_get_dentry, .get_parent = efs_get_parent, }; |