diff options
author | Pavel Shilovsky <pshilovsky@samba.org> | 2014-08-22 13:32:09 +0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-10-05 14:54:11 -0700 |
commit | c8d26061c949d8acb7a69b862f2d1a37f36dac44 (patch) | |
tree | 91dd10deaee01ceda88e143720e181198eb345ac /fs/cifs/readdir.c | |
parent | 8e485734eb4e96853cd14e4d30ea40605b0e8e83 (diff) | |
download | linux-3.10-c8d26061c949d8acb7a69b862f2d1a37f36dac44.tar.gz linux-3.10-c8d26061c949d8acb7a69b862f2d1a37f36dac44.tar.bz2 linux-3.10-c8d26061c949d8acb7a69b862f2d1a37f36dac44.zip |
CIFS: Fix directory rename error
commit a07d322059db66b84c9eb4f98959df468e88b34b upstream.
CIFS servers process nlink counts differently for files and directories.
In cifs_rename() if we the request fails on the existing target, we
try to remove it through cifs_unlink() but this is not what we want
to do for directories. As the result the following sequence of commands
mkdir {1,2}; mv -T 1 2; rmdir {1,2}; mkdir {1,2}; echo foo > 2/bar
and XFS test generic/023 fail with -ENOENT error. That's why the second
mkdir reuses the existing inode (target inode of the mv -T command) with
S_DEAD flag.
Fix this by checking whether the target is directory or not and
calling cifs_rmdir() rather than cifs_unlink() for directories.
Signed-off-by: Pavel Shilovsky <pshilovsky@samba.org>
Signed-off-by: Steve French <smfrench@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/cifs/readdir.c')
0 files changed, 0 insertions, 0 deletions