diff options
| author | Julia Lawall <julia@diku.dk> | 2009-07-11 09:50:09 +0200 |
|---|---|---|
| committer | Dave Airlie <airlied@linux.ie> | 2009-07-15 16:56:48 +1000 |
| commit | ecca0683230b83e8f830ff157911fad20bc43015 (patch) | |
| tree | 95d69ae4726d58b80a44fb7c9ef3702b5e5e34a6 /drivers | |
| parent | ba0ab82358a12e7a7f2872d6b65c437157c6888f (diff) | |
| download | linux-3.10-ecca0683230b83e8f830ff157911fad20bc43015.tar.gz linux-3.10-ecca0683230b83e8f830ff157911fad20bc43015.tar.bz2 linux-3.10-ecca0683230b83e8f830ff157911fad20bc43015.zip | |
drm: Move a dereference below a NULL test
If the NULL test is necessary, then the dereference should be moved below
the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Dave Airlie <airlied@linux.ie>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/drm_stub.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_stub.c b/drivers/gpu/drm/drm_stub.c index 155a5bbce68..55bb8a82d61 100644 --- a/drivers/gpu/drm/drm_stub.c +++ b/drivers/gpu/drm/drm_stub.c @@ -489,7 +489,7 @@ int drm_put_minor(struct drm_minor **minor_p) */ void drm_put_dev(struct drm_device *dev) { - struct drm_driver *driver = dev->driver; + struct drm_driver *driver; struct drm_map_list *r_list, *list_temp; DRM_DEBUG("\n"); @@ -498,6 +498,7 @@ void drm_put_dev(struct drm_device *dev) DRM_ERROR("cleanup called no dev\n"); return; } + driver = dev->driver; drm_vblank_cleanup(dev); |