summaryrefslogtreecommitdiff
path: root/drivers/video
diff options
context:
space:
mode:
authorDevendra Naga <devendra.aaru@gmail.com>2013-02-21 16:43:52 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2013-02-21 17:22:24 -0800
commitaea00a6c370cff79b58503c012943d6a298eb527 (patch)
tree0ef16f0facb6959a2ddc379af788d37ba2cdc19a /drivers/video
parent47cf076b4407010573dee9eadc998ff9ecf8397c (diff)
downloadlinux-3.10-aea00a6c370cff79b58503c012943d6a298eb527.tar.gz
linux-3.10-aea00a6c370cff79b58503c012943d6a298eb527.tar.bz2
linux-3.10-aea00a6c370cff79b58503c012943d6a298eb527.zip
drivers/video/backlight/lm3639_bl.c: remove ret = -EIO at error paths of probe
The APIs are returning correctly the err codes, no need to assign -EIO to the ret again. Signed-off-by: Devendra Naga <devendra.aaru@gmail.com> Acked-by: Daniel Jeong <daniel.jeong@ti.com> Cc: G.Shark Jeong <gshark.jeong@gmail.com> Acked-by: Jingoo Han <jg1.han@samsung.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video')
-rw-r--r--drivers/video/backlight/lm3639_bl.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c
index 7ab2d2a04e4..053964da8dd 100644
--- a/drivers/video/backlight/lm3639_bl.c
+++ b/drivers/video/backlight/lm3639_bl.c
@@ -350,14 +350,13 @@ static int lm3639_probe(struct i2c_client *client,
&lm3639_bled_ops, &props);
if (IS_ERR(pchip->bled)) {
dev_err(&client->dev, "fail : backlight register\n");
- ret = -EIO;
+ ret = PTR_ERR(pchip->bled);
goto err_out;
}
ret = device_create_file(&(pchip->bled->dev), &dev_attr_bled_mode);
if (ret < 0) {
dev_err(&client->dev, "failed : add sysfs entries\n");
- ret = -EIO;
goto err_bled_mode;
}
@@ -369,7 +368,6 @@ static int lm3639_probe(struct i2c_client *client,
&client->dev, &pchip->cdev_flash);
if (ret < 0) {
dev_err(&client->dev, "fail : flash register\n");
- ret = -EIO;
goto err_flash;
}
@@ -381,7 +379,6 @@ static int lm3639_probe(struct i2c_client *client,
&client->dev, &pchip->cdev_torch);
if (ret < 0) {
dev_err(&client->dev, "fail : torch register\n");
- ret = -EIO;
goto err_torch;
}