diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2007-06-15 15:44:13 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-07-12 16:34:35 -0700 |
| commit | 23189aee76c3297c7ff797ca8bc8e314783039ef (patch) | |
| tree | 83463bf5a471ccf40f3de9455614139f5588f872 /drivers/usb/serial/keyspan_pda.c | |
| parent | 95b934548049e2fd6a67853c6b5055c073bf6961 (diff) | |
| download | linux-3.10-23189aee76c3297c7ff797ca8bc8e314783039ef.tar.gz linux-3.10-23189aee76c3297c7ff797ca8bc8e314783039ef.tar.bz2 linux-3.10-23189aee76c3297c7ff797ca8bc8e314783039ef.zip | |
USB: serial: keyspan_pda: clean up urb->status usage
This done in anticipation of removal of urb->status, which will make
that patch easier to review and apply in the future.
Cc: <linux-usb-devel@lists.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/keyspan_pda.c')
| -rw-r--r-- | drivers/usb/serial/keyspan_pda.c | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c index dd0b66a6ed5..be9ac20a8f1 100644 --- a/drivers/usb/serial/keyspan_pda.c +++ b/drivers/usb/serial/keyspan_pda.c @@ -218,11 +218,12 @@ static void keyspan_pda_rx_interrupt (struct urb *urb) struct tty_struct *tty = port->tty; unsigned char *data = urb->transfer_buffer; int i; - int status; + int retval; + int status = urb->status; struct keyspan_pda_private *priv; priv = usb_get_serial_port_data(port); - switch (urb->status) { + switch (status) { case 0: /* success */ break; @@ -230,10 +231,12 @@ static void keyspan_pda_rx_interrupt (struct urb *urb) case -ENOENT: case -ESHUTDOWN: /* this urb is terminated, clean up */ - dbg("%s - urb shutting down with status: %d", __FUNCTION__, urb->status); + dbg("%s - urb shutting down with status: %d", + __FUNCTION__, status); return; default: - dbg("%s - nonzero urb status received: %d", __FUNCTION__, urb->status); + dbg("%s - nonzero urb status received: %d", + __FUNCTION__, status); goto exit; } @@ -268,10 +271,10 @@ static void keyspan_pda_rx_interrupt (struct urb *urb) } exit: - status = usb_submit_urb (urb, GFP_ATOMIC); - if (status) + retval = usb_submit_urb (urb, GFP_ATOMIC); + if (retval) err ("%s - usb_submit_urb failed with result %d", - __FUNCTION__, status); + __FUNCTION__, retval); } |