summaryrefslogtreecommitdiff
path: root/drivers/usb/gadget/amd5536udc.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2010-08-28 18:48:56 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2010-10-22 10:21:26 -0700
commit0cf7a6338808d702c256778188516a16805e6145 (patch)
treea7b5a40fc5c141fc7f6f60484592a7aacd1d7a0c /drivers/usb/gadget/amd5536udc.c
parent5ea081785dde6041eb2f4acc2369abbb9099a981 (diff)
downloadlinux-3.10-0cf7a6338808d702c256778188516a16805e6145.tar.gz
linux-3.10-0cf7a6338808d702c256778188516a16805e6145.tar.bz2
linux-3.10-0cf7a6338808d702c256778188516a16805e6145.zip
USB: gadget: amd5536udc.c: Remove double test
The same expression is tested twice and the result is the same each time. Instead test for use_dma_ppb as in the test above. The sematic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @expression@ expression E; @@ ( * E || ... || E | * E && ... && E ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/gadget/amd5536udc.c')
-rw-r--r--drivers/usb/gadget/amd5536udc.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index fadebfd53b4..2b361500af1 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -203,7 +203,7 @@ static void print_regs(struct udc *dev)
DBG(dev, "DMA mode = PPBNDU (packet per buffer "
"WITHOUT desc. update)\n");
dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBNDU");
- } else if (use_dma && use_dma_ppb_du && use_dma_ppb_du) {
+ } else if (use_dma && use_dma_ppb && use_dma_ppb_du) {
DBG(dev, "DMA mode = PPBDU (packet per buffer "
"WITH desc. update)\n");
dev_info(&dev->pdev->dev, "DMA mode (%s)\n", "PPBDU");