diff options
| author | Tomasz Figa <t.figa@samsung.com> | 2013-05-08 18:30:30 +0200 |
|---|---|---|
| committer | Chanho Park <chanho61.park@samsung.com> | 2014-11-18 11:43:24 +0900 |
| commit | 4fccb568a00333313b6be5df02389b937a88e2fd (patch) | |
| tree | 88b07888a357777df12864166fdefdecfcfc177b /drivers/tty | |
| parent | f1a7fb060d58282a2bfab131273aa343ce1de0ad (diff) | |
| download | linux-3.10-4fccb568a00333313b6be5df02389b937a88e2fd.tar.gz linux-3.10-4fccb568a00333313b6be5df02389b937a88e2fd.tar.bz2 linux-3.10-4fccb568a00333313b6be5df02389b937a88e2fd.zip | |
tty: serial: samsung: Remove useless checks in suspend/resume callbacks
Since uart_port struct exists through whole driver lifetime, there is no
need to check if it is non-NULL in suspend/resume callbacks.
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/serial/samsung.c | 31 |
1 files changed, 13 insertions, 18 deletions
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index 0c8a9fa2be6..12bb5d877d3 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c @@ -1307,8 +1307,7 @@ static int s3c24xx_serial_suspend(struct device *dev) { struct uart_port *port = s3c24xx_dev_to_port(dev); - if (port) - uart_suspend_port(&s3c24xx_uart_drv, port); + uart_suspend_port(&s3c24xx_uart_drv, port); return 0; } @@ -1318,13 +1317,11 @@ static int s3c24xx_serial_resume(struct device *dev) struct uart_port *port = s3c24xx_dev_to_port(dev); struct s3c24xx_uart_port *ourport = to_ourport(port); - if (port) { - clk_prepare_enable(ourport->clk); - s3c24xx_serial_resetport(port, s3c24xx_port_to_cfg(port)); - clk_disable_unprepare(ourport->clk); + clk_prepare_enable(ourport->clk); + s3c24xx_serial_resetport(port, s3c24xx_port_to_cfg(port)); + clk_disable_unprepare(ourport->clk); - uart_resume_port(&s3c24xx_uart_drv, port); - } + uart_resume_port(&s3c24xx_uart_drv, port); return 0; } @@ -1333,16 +1330,14 @@ static int s3c24xx_serial_resume_noirq(struct device *dev) { struct uart_port *port = s3c24xx_dev_to_port(dev); - if (port) { - /* restore IRQ mask */ - if (s3c24xx_serial_has_interrupt_mask(port)) { - unsigned int uintm = 0xf; - if (tx_enabled(port)) - uintm &= ~S3C64XX_UINTM_TXD_MSK; - if (rx_enabled(port)) - uintm &= ~S3C64XX_UINTM_RXD_MSK; - wr_regl(port, S3C64XX_UINTM, uintm); - } + /* restore IRQ mask */ + if (s3c24xx_serial_has_interrupt_mask(port)) { + unsigned int uintm = 0xf; + if (tx_enabled(port)) + uintm &= ~S3C64XX_UINTM_TXD_MSK; + if (rx_enabled(port)) + uintm &= ~S3C64XX_UINTM_RXD_MSK; + wr_regl(port, S3C64XX_UINTM, uintm); } return 0; |