summaryrefslogtreecommitdiff
path: root/drivers/staging
diff options
context:
space:
mode:
authorPeter Huewe <peterhuewe@gmx.de>2013-01-26 00:40:13 +0100
committerRob Clark <robdclark@gmail.com>2013-02-16 17:38:05 -0500
commita4462f246c8821f625f45bce52c7ca7e0207dffe (patch)
tree76476771ac742e3df978583960c05b9585a3a0e3 /drivers/staging
parent32ac1a5286d56b3c822f4a1a8d0f7fc5d586de38 (diff)
downloadlinux-3.10-a4462f246c8821f625f45bce52c7ca7e0207dffe.tar.gz
linux-3.10-a4462f246c8821f625f45bce52c7ca7e0207dffe.tar.bz2
linux-3.10-a4462f246c8821f625f45bce52c7ca7e0207dffe.zip
staging/omapdrm: Use kmemdup rather than duplicating its implementation
Found with coccicheck. The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> Signed-off-by: Rob Clark <rob@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/omapdrm/omap_gem.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/omapdrm/omap_gem.c b/drivers/staging/omapdrm/omap_gem.c
index 08f1e292ed2..f9297eb2599 100644
--- a/drivers/staging/omapdrm/omap_gem.c
+++ b/drivers/staging/omapdrm/omap_gem.c
@@ -1267,12 +1267,12 @@ int omap_gem_set_sync_object(struct drm_gem_object *obj, void *syncobj)
if ((omap_obj->flags & OMAP_BO_EXT_SYNC) && !syncobj) {
/* clearing a previously set syncobj */
- syncobj = kzalloc(sizeof(*omap_obj->sync), GFP_ATOMIC);
+ syncobj = kmemdup(omap_obj->sync, sizeof(*omap_obj->sync),
+ GFP_ATOMIC);
if (!syncobj) {
ret = -ENOMEM;
goto unlock;
}
- memcpy(syncobj, omap_obj->sync, sizeof(*omap_obj->sync));
omap_obj->flags &= ~OMAP_BO_EXT_SYNC;
omap_obj->sync = syncobj;
} else if (syncobj && !(omap_obj->flags & OMAP_BO_EXT_SYNC)) {