diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-10-30 20:13:51 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-30 21:52:11 -0700 |
| commit | 8d6b283d97db2d4d8fb6d1b8cfc630906f883f2f (patch) | |
| tree | 59dcc5524f81101a5f4be1636faf19386b0fc1b7 /drivers/scsi | |
| parent | e623c2cdb5b9151e1ca8c846e2814977ba4dfcac (diff) | |
| download | linux-3.10-8d6b283d97db2d4d8fb6d1b8cfc630906f883f2f.tar.gz linux-3.10-8d6b283d97db2d4d8fb6d1b8cfc630906f883f2f.tar.bz2 linux-3.10-8d6b283d97db2d4d8fb6d1b8cfc630906f883f2f.zip | |
SCSI: megaraid: missing bounds check in mimd_to_kioc()
commit 3de2260140417759c669d391613d583baf03b0cf upstream.
pthru32->dataxferlen comes from the user so we need to check that it's
not too large so we don't overflow the buffer.
Reported-by: Nico Golde <nico@ngolde.de>
Reported-by: Fabian Yamaguchi <fabs@goesec.de>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sumit Saxena <sumit.saxena@lsi.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/scsi')
| -rw-r--r-- | drivers/scsi/megaraid/megaraid_mm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c index 25506c77738..9bec1717047 100644 --- a/drivers/scsi/megaraid/megaraid_mm.c +++ b/drivers/scsi/megaraid/megaraid_mm.c @@ -486,6 +486,8 @@ mimd_to_kioc(mimd_t __user *umimd, mraid_mmadp_t *adp, uioc_t *kioc) pthru32->dataxferaddr = kioc->buf_paddr; if (kioc->data_dir & UIOC_WR) { + if (pthru32->dataxferlen > kioc->xferlen) + return -EINVAL; if (copy_from_user(kioc->buf_vaddr, kioc->user_data, pthru32->dataxferlen)) { return (-EFAULT); |