diff options
| author | Michael Holzheu <holzheu@de.ibm.com> | 2007-10-12 16:11:44 +0200 |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2007-10-12 16:13:09 +0200 |
| commit | 53a0868cb4d77dcba8e95e1033361ffdb6e510e2 (patch) | |
| tree | ba104b7f4dd00a2713dc9acff360cb7013060cfd /drivers/s390 | |
| parent | cebe0fe70fbf033a1a6b7c5c8b79eb13060a4ab7 (diff) | |
| download | linux-3.10-53a0868cb4d77dcba8e95e1033361ffdb6e510e2.tar.gz linux-3.10-53a0868cb4d77dcba8e95e1033361ffdb6e510e2.tar.bz2 linux-3.10-53a0868cb4d77dcba8e95e1033361ffdb6e510e2.zip | |
[S390] zcore: fix inline assembly in memcpy_real()
memcpy_real uses the mvcle instruction. This instruction alters all used
registers (source, destination and 2 x count). Therefore we have to flag
those registers as input/output registers (+d). In addition to that, we
have to specify, that we read from memory designated by "src" and write to
memory designated by "dest".
Signed-off-by: Michael Holzheu <holzheu@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/char/zcore.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/s390/char/zcore.c b/drivers/s390/char/zcore.c index 3712ede1672..7073daf7798 100644 --- a/drivers/s390/char/zcore.c +++ b/drivers/s390/char/zcore.c @@ -141,15 +141,16 @@ static int memcpy_real(void *dest, unsigned long src, size_t count) if (count == 0) return 0; - flags = __raw_local_irq_stnsm(0xf8); /* switch to real mode */ + flags = __raw_local_irq_stnsm(0xf8UL); /* switch to real mode */ asm volatile ( "0: mvcle %1,%2,0x0\n" "1: jo 0b\n" " lhi %0,0x0\n" "2:\n" EX_TABLE(1b,2b) - : "+d" (rc) - : "d" (_dest), "d" (_src), "d" (_len1), "d" (_len2) + : "+d" (rc), "+d" (_dest), "+d" (_src), "+d" (_len1), + "+d" (_len2), "=m" (*((long*)dest)) + : "m" (*((long*)src)) : "cc", "memory"); __raw_local_irq_ssm(flags); |