diff options
| author | Eric Dumazet <edumazet@google.com> | 2014-06-06 06:44:03 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-06-26 15:12:38 -0400 |
| commit | 6a827d8a67f750f3096e668657e16d479363d4b5 (patch) | |
| tree | 11687aa90e59cc27704f62682f915ae2e2f38088 /drivers/net | |
| parent | 9deb5f0852ddb318511605433367fcb02a738dc2 (diff) | |
| download | linux-3.10-6a827d8a67f750f3096e668657e16d479363d4b5.tar.gz linux-3.10-6a827d8a67f750f3096e668657e16d479363d4b5.tar.bz2 linux-3.10-6a827d8a67f750f3096e668657e16d479363d4b5.zip | |
net: force a list_del() in unregister_netdevice_many()
[ Upstream commit 87757a917b0b3c0787e0563c679762152be81312 ]
unregister_netdevice_many() API is error prone and we had too
many bugs because of dangling LIST_HEAD on stacks.
See commit f87e6f47933e3e ("net: dont leave active on stack LIST_HEAD")
In fact, instead of making sure no caller leaves an active list_head,
just force a list_del() in the callee. No one seems to need to access
the list after unregister_netdevice_many()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/macvlan.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index c12aeaee22f..155ef4bbde9 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -961,7 +961,6 @@ static int macvlan_device_event(struct notifier_block *unused, list_for_each_entry_safe(vlan, next, &port->vlans, list) vlan->dev->rtnl_link_ops->dellink(vlan->dev, &list_kill); unregister_netdevice_many(&list_kill); - list_del(&list_kill); break; case NETDEV_PRE_TYPE_CHANGE: /* Forbid underlaying device to change its type. */ |