diff options
author | Matt Carlson <mcarlson@broadcom.com> | 2009-10-05 17:55:29 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-10-07 03:37:39 -0700 |
commit | 24bb4fb6dac59f220f42fb375ba0e0f19365a227 (patch) | |
tree | f3c14601de35332b12260e89526426c220578121 /drivers/net/tg3.h | |
parent | 083925d5432d910025e84d445d1243dd260d4afb (diff) | |
download | linux-3.10-24bb4fb6dac59f220f42fb375ba0e0f19365a227.tar.gz linux-3.10-24bb4fb6dac59f220f42fb375ba0e0f19365a227.tar.bz2 linux-3.10-24bb4fb6dac59f220f42fb375ba0e0f19365a227.zip |
tg3: Fix phylib locking strategy
Felix Radensky noted that chip resets were generating stack trace dumps.
This is because the driver is attempting to acquire the mdio bus mutex
while holding the tp->lock spinlock. The fix is to change the code such
that every phy access takes the tp->lock spinlock instead.
Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tg3.h')
-rw-r--r-- | drivers/net/tg3.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/tg3.h b/drivers/net/tg3.h index 524691cd989..bab7940158e 100644 --- a/drivers/net/tg3.h +++ b/drivers/net/tg3.h @@ -2748,7 +2748,6 @@ struct tg3 { #define TG3_FLG3_5701_DMA_BUG 0x00000008 #define TG3_FLG3_USE_PHYLIB 0x00000010 #define TG3_FLG3_MDIOBUS_INITED 0x00000020 -#define TG3_FLG3_MDIOBUS_PAUSED 0x00000040 #define TG3_FLG3_PHY_CONNECTED 0x00000080 #define TG3_FLG3_RGMII_STD_IBND_DISABLE 0x00000100 #define TG3_FLG3_RGMII_EXT_IBND_RX_EN 0x00000200 |