diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2009-02-27 13:08:03 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-03-02 03:15:05 -0800 |
| commit | 8129d2173ea7a5b030b4cba044d1f92689895083 (patch) | |
| tree | 0ae9108fa888fbed0f4b846e17c27f6b44cd3c6e /drivers/net/sfc/net_driver.h | |
| parent | b4a44a69877960e620461c663805f7cc52e2a798 (diff) | |
| download | linux-3.10-8129d2173ea7a5b030b4cba044d1f92689895083.tar.gz linux-3.10-8129d2173ea7a5b030b4cba044d1f92689895083.tar.bz2 linux-3.10-8129d2173ea7a5b030b4cba044d1f92689895083.zip | |
sfc: Clean up LED control
Reinitialise LEDs after overriding them for identification.
Rename set_fault_led method to set_id_led since we always use it for
NIC identification and not faults.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc/net_driver.h')
| -rw-r--r-- | drivers/net/sfc/net_driver.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/sfc/net_driver.h b/drivers/net/sfc/net_driver.h index ebc7b6340fb..b81fc727dff 100644 --- a/drivers/net/sfc/net_driver.h +++ b/drivers/net/sfc/net_driver.h @@ -402,8 +402,8 @@ struct efx_blinker { * @major: Major rev. ('A', 'B' ...) * @minor: Minor rev. (0, 1, ...) * @init: Initialisation function - * @init_leds: Sets up board LEDs - * @set_fault_led: Turns the fault LED on or off + * @init_leds: Sets up board LEDs. May be called repeatedly. + * @set_id_led: Turns the identification LED on or off * @blink: Starts/stops blinking * @monitor: Board-specific health check function * @fini: Cleanup function @@ -419,9 +419,9 @@ struct efx_board { /* As the LEDs are typically attached to the PHY, LEDs * have a separate init callback that happens later than * board init. */ - int (*init_leds)(struct efx_nic *efx); + void (*init_leds)(struct efx_nic *efx); + void (*set_id_led) (struct efx_nic *efx, bool state); int (*monitor) (struct efx_nic *nic); - void (*set_fault_led) (struct efx_nic *efx, bool state); void (*blink) (struct efx_nic *efx, bool start); void (*fini) (struct efx_nic *nic); struct efx_blinker blinker; |