diff options
| author | Josef Gajdusek <atx@atx.name> | 2014-05-11 14:40:44 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-06-07 13:25:31 -0700 |
| commit | a026e5ef61620e4f8fcacfabd88ad3c1d5f79cd1 (patch) | |
| tree | c101b12c188f28f8a9e1b8f5c543aeb40d9a06bc /drivers/hwmon | |
| parent | d13ab64e7a9b68da0c1354085e2277778026b86a (diff) | |
| download | linux-3.10-a026e5ef61620e4f8fcacfabd88ad3c1d5f79cd1.tar.gz linux-3.10-a026e5ef61620e4f8fcacfabd88ad3c1d5f79cd1.tar.bz2 linux-3.10-a026e5ef61620e4f8fcacfabd88ad3c1d5f79cd1.zip | |
hwmon: (emc1403) fix inverted store_hyst()
commit 17c048fc4bd95efea208a1920f169547d8588f1f upstream.
Attempts to set the hysteresis value to a temperature below the target
limit fails with "write error: Numerical result out of range" due to
an inverted comparison.
Signed-off-by: Josef Gajdusek <atx@atx.name>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
[Guenter Roeck: Updated headline and description]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/emc1403.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/emc1403.c b/drivers/hwmon/emc1403.c index 142e1cb8dea..62fba71ef3c 100644 --- a/drivers/hwmon/emc1403.c +++ b/drivers/hwmon/emc1403.c @@ -162,7 +162,7 @@ static ssize_t store_hyst(struct device *dev, if (retval < 0) goto fail; - hyst = val - retval * 1000; + hyst = retval * 1000 - val; hyst = DIV_ROUND_CLOSEST(hyst, 1000); if (hyst < 0 || hyst > 255) { retval = -ERANGE; |