diff options
| author | Axel Lin <axel.lin@ingics.com> | 2014-08-02 13:36:38 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-09-05 16:28:35 -0700 |
| commit | 6dbbe154751f97308e0cd029f0b15f7685897ecf (patch) | |
| tree | 6693944cde43beca5bad93f8569534d99a8849f9 /drivers/hwmon | |
| parent | 070d6526cc0b0402c44868b31957d39b5d40cdd2 (diff) | |
| download | linux-3.10-6dbbe154751f97308e0cd029f0b15f7685897ecf.tar.gz linux-3.10-6dbbe154751f97308e0cd029f0b15f7685897ecf.tar.bz2 linux-3.10-6dbbe154751f97308e0cd029f0b15f7685897ecf.zip | |
hwmon: (gpio-fan) Prevent overflow problem when writing large limits
commit 2565fb05d1e9fc0831f7b1c083bcfcb1cba1f020 upstream.
On platforms with sizeof(int) < sizeof(unsigned long), writing a rpm value
larger than MAXINT will result in unpredictable limit values written to the
chip. Avoid auto-conversion from unsigned long to int to fix the problem.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/gpio-fan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index 3104149795c..ce1d82762ba 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c @@ -172,7 +172,7 @@ static int get_fan_speed_index(struct gpio_fan_data *fan_data) return -EINVAL; } -static int rpm_to_speed_index(struct gpio_fan_data *fan_data, int rpm) +static int rpm_to_speed_index(struct gpio_fan_data *fan_data, unsigned long rpm) { struct gpio_fan_speed *speed = fan_data->speed; int i; |