summaryrefslogtreecommitdiff
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-07-02 08:29:55 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-07-17 15:58:00 -0700
commitc1bf93008b500736d62dcad4e8f6bd9eb558bc12 (patch)
tree66d419a134678fb21f3764abd887963f3ced7cfb /drivers/hwmon
parent787c2837b3712e8d5b18a88e3827099f22f184ce (diff)
downloadlinux-3.10-c1bf93008b500736d62dcad4e8f6bd9eb558bc12.tar.gz
linux-3.10-c1bf93008b500736d62dcad4e8f6bd9eb558bc12.tar.bz2
linux-3.10-c1bf93008b500736d62dcad4e8f6bd9eb558bc12.zip
hwmon: (adm1029) Ensure the fan_div cache is updated in set_fan_div
commit 1035a9e3e9c76b64a860a774f5b867d28d34acc2 upstream. Writing to fanX_div does not clear the cache. As a result, reading from fanX_div may return the old value for up to two seconds after writing a new value. This patch ensures the fan_div cache is updated in set_fan_div(). Reported-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Axel Lin <axel.lin@ingics.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/adm1029.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
index 9ee5e066423..39441e5d922 100644
--- a/drivers/hwmon/adm1029.c
+++ b/drivers/hwmon/adm1029.c
@@ -232,6 +232,9 @@ static ssize_t set_fan_div(struct device *dev,
/* Update the value */
reg = (reg & 0x3F) | (val << 6);
+ /* Update the cache */
+ data->fan_div[attr->index] = reg;
+
/* Write value */
i2c_smbus_write_byte_data(client,
ADM1029_REG_FAN_DIV[attr->index], reg);