diff options
| author | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2012-03-04 14:24:31 +0100 |
|---|---|---|
| committer | Stefan Richter <stefanr@s5r6.in-berlin.de> | 2012-03-10 17:41:19 +0100 |
| commit | 98466cc4502b3171f1bdc146db0d2106fcbc3f4f (patch) | |
| tree | 40dd97e187c4ce9217a71d94b51176b2e3f4e97c /drivers/firewire | |
| parent | c13ccfcf66b2e70f8d01f7fe7e1e20ba60e733e1 (diff) | |
| download | linux-3.10-98466cc4502b3171f1bdc146db0d2106fcbc3f4f.tar.gz linux-3.10-98466cc4502b3171f1bdc146db0d2106fcbc3f4f.tar.bz2 linux-3.10-98466cc4502b3171f1bdc146db0d2106fcbc3f4f.zip | |
firewire: tone down some diagnostic log messages
The "skipped bus generations" message was added together with the
respective fw_device retaining/ reviving code in order to see how it all
works out. It did well, so don't spam the log anymore.
The "register access failure" situation still needs an actual handler.
But at this point it makes less sense to ask folks to send mails about
it. We now have a pretty good picture of what controllers emit this and
when:
Texas Instruments PCIxx21 FireWire + CardBus + flash memory card
controller:
https://bugzilla.redhat.com/show_bug.cgi?id=608544
O2 Micro FireWire + flash memory card controller:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/801719
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/881688
http://marc.info/?l=linux1394-devel&m=132309283531423
http://marc.info/?l=linux1394-devel&m=132368567907469
http://marc.info/?l=linux1394-devel&m=132516165727468
http://marc.info/?l=linux1394-devel&m=133006486927699
Pinnacle Movieboard:
commit 7f7e37115a8b6724f26d0637a04e1d35e3c59717
http://marc.info/?l=linux1394-devel&m=130714243325962
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Diffstat (limited to 'drivers/firewire')
| -rw-r--r-- | drivers/firewire/core-topology.c | 1 | ||||
| -rw-r--r-- | drivers/firewire/ohci.c | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/drivers/firewire/core-topology.c b/drivers/firewire/core-topology.c index 75a6b0df670..255646ffc35 100644 --- a/drivers/firewire/core-topology.c +++ b/drivers/firewire/core-topology.c @@ -530,7 +530,6 @@ void fw_core_handle_bus_reset(struct fw_card *card, int node_id, int generation, */ if (!is_next_generation(generation, card->generation) && card->local_node != NULL) { - fw_notice(card, "skipped bus generations, destroying all nodes\n"); fw_destroy_nodes(card); card->bm_retries = 0; } diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 68b3c1b635f..ee235b53777 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -2076,8 +2076,7 @@ static irqreturn_t irq_handler(int irq, void *data) } if (unlikely(event & OHCI1394_regAccessFail)) - dev_err(ohci->card.device, - "register access failure - please notify linux1394-devel@lists.sf.net\n"); + dev_err(ohci->card.device, "register access failure\n"); if (unlikely(event & OHCI1394_postedWriteErr)) { reg_read(ohci, OHCI1394_PostedWriteAddressHi); |