diff options
author | Alex Chiang <achiang@hp.com> | 2009-12-14 17:59:06 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-12-15 08:53:17 -0800 |
commit | f8246f3159dfdf97b8b40f9e03e715bafedd22fc (patch) | |
tree | 1e0b87b800a6efbba7c963665c1f129e208a6293 /drivers/base | |
parent | dee5d0d518defd0337a41f1a504428c9acc87be5 (diff) | |
download | linux-3.10-f8246f3159dfdf97b8b40f9e03e715bafedd22fc.tar.gz linux-3.10-f8246f3159dfdf97b8b40f9e03e715bafedd22fc.tar.bz2 linux-3.10-f8246f3159dfdf97b8b40f9e03e715bafedd22fc.zip |
mm: refactor register_cpu_under_node()
By returning early if the node is not online, we can unindent the
interesting code by one level.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com>
Cc: Gary Hade <garyhade@us.ibm.com>
Cc: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: David Rientjes <rientjes@google.com>
Cc: Greg KH <greg@kroah.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Rientjes <rientjes@google.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/base')
-rw-r--r-- | drivers/base/node.c | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/drivers/base/node.c b/drivers/base/node.c index 44eed11bbdf..eeae035dadc 100644 --- a/drivers/base/node.c +++ b/drivers/base/node.c @@ -271,16 +271,18 @@ struct node node_devices[MAX_NUMNODES]; */ int register_cpu_under_node(unsigned int cpu, unsigned int nid) { - if (node_online(nid)) { - struct sys_device *obj = get_cpu_sysdev(cpu); - if (!obj) - return 0; - return sysfs_create_link(&node_devices[nid].sysdev.kobj, - &obj->kobj, - kobject_name(&obj->kobj)); - } + struct sys_device *obj; - return 0; + if (!node_online(nid)) + return 0; + + obj = get_cpu_sysdev(cpu); + if (!obj) + return 0; + + return sysfs_create_link(&node_devices[nid].sysdev.kobj, + &obj->kobj, + kobject_name(&obj->kobj)); } int unregister_cpu_under_node(unsigned int cpu, unsigned int nid) |