diff options
| author | Sebastian Ott <sebott@linux.vnet.ibm.com> | 2012-07-17 10:39:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-07-17 10:40:23 -0700 |
| commit | a14af325641794d1ce8e676e9c4967342349195c (patch) | |
| tree | 5f59e8d8b1d224651895e2fdad3172b15415bdd2 /drivers/base/driver.c | |
| parent | db1b9037424b8219449a6754e9b7e97b0523c426 (diff) | |
| download | linux-3.10-a14af325641794d1ce8e676e9c4967342349195c.tar.gz linux-3.10-a14af325641794d1ce8e676e9c4967342349195c.tar.bz2 linux-3.10-a14af325641794d1ce8e676e9c4967342349195c.zip | |
driver core: don't trigger uevent after failure
Do not send the uevent if driver_add_groups failed.
Reported-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/base/driver.c')
| -rw-r--r-- | drivers/base/driver.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/base/driver.c b/drivers/base/driver.c index 1b500d6fcc2..974e301a1ef 100644 --- a/drivers/base/driver.c +++ b/drivers/base/driver.c @@ -185,9 +185,10 @@ int driver_register(struct device_driver *drv) if (ret) return ret; ret = driver_add_groups(drv, drv->groups); - if (ret) + if (ret) { bus_remove_driver(drv); - + return ret; + } kobject_uevent(&drv->p->kobj, KOBJ_ADD); return ret; |