diff options
| author | Tejun Heo <tj@kernel.org> | 2009-09-17 18:45:27 +0900 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@redhat.com> | 2009-09-17 16:45:40 -0400 |
| commit | 4dc738ed2adf28f62f46dd53ef700a51603777f7 (patch) | |
| tree | 2a7bab5698c431eae473e8df4a7b6ab10af27566 /drivers/ata | |
| parent | 31b239ad1ba7225435e13f5afc47e48eb674c0cc (diff) | |
| download | linux-3.10-4dc738ed2adf28f62f46dd53ef700a51603777f7.tar.gz linux-3.10-4dc738ed2adf28f62f46dd53ef700a51603777f7.tar.bz2 linux-3.10-4dc738ed2adf28f62f46dd53ef700a51603777f7.zip | |
libata: fix spurious WARN_ON_ONCE() on port freeze
Commit 54c38444fad6a99b4b19512f8f0055d69115e69e makes libata abort qcs
after the port is frozen. This is necessary to guarantee that TF
registers are accessed after the DMA engine is shutdown after an
error. However, this triggers WARN_ON_ONCE() check in
ata_qc_complete() spuriously. Move WARN_ON_ONCE() downwards such that
failing commands while frozen doesn't trigger it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Diffstat (limited to 'drivers/ata')
| -rw-r--r-- | drivers/ata/libata-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index df31deac5c8..0ddaf43d68c 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -5024,8 +5024,6 @@ void ata_qc_complete(struct ata_queued_cmd *qc) struct ata_device *dev = qc->dev; struct ata_eh_info *ehi = &dev->link->eh_info; - WARN_ON_ONCE(ap->pflags & ATA_PFLAG_FROZEN); - if (unlikely(qc->err_mask)) qc->flags |= ATA_QCFLAG_FAILED; @@ -5038,6 +5036,8 @@ void ata_qc_complete(struct ata_queued_cmd *qc) } } + WARN_ON_ONCE(ap->pflags & ATA_PFLAG_FROZEN); + /* read result TF if requested */ if (qc->flags & ATA_QCFLAG_RESULT_TF) fill_result_tf(qc); |