diff options
author | Roel Kluin <roel.kluin@gmail.com> | 2009-06-08 13:04:43 +0200 |
---|---|---|
committer | Jesper Nilsson <jesper.nilsson@axis.com> | 2009-06-08 13:05:19 +0200 |
commit | b0903ee8e4853eea35cb24cfb4dda1b60c7948dc (patch) | |
tree | 37c75f4c3f0fe13aa85b84f0ad8e587468e78a42 /arch/cris | |
parent | ccc0d38ec13d4649d4168c1db590137df53ad783 (diff) | |
download | linux-3.10-b0903ee8e4853eea35cb24cfb4dda1b60c7948dc.tar.gz linux-3.10-b0903ee8e4853eea35cb24cfb4dda1b60c7948dc.tar.bz2 linux-3.10-b0903ee8e4853eea35cb24cfb4dda1b60c7948dc.zip |
CRIS: assignment/is equal confusion
Somehow, the assignments of rw->lock got written as comparisons.
The effect probably was that the read-write spinlocks never locked.
However, since the locks are only used in CONFIG_SMP and SMP CRIS is
experimental, it has never been identified as a problem.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
Diffstat (limited to 'arch/cris')
-rw-r--r-- | arch/cris/include/arch-v32/arch/spinlock.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/arch/cris/include/arch-v32/arch/spinlock.h b/arch/cris/include/arch-v32/arch/spinlock.h index 129756b9666..367a53ea10c 100644 --- a/arch/cris/include/arch-v32/arch/spinlock.h +++ b/arch/cris/include/arch-v32/arch/spinlock.h @@ -78,7 +78,7 @@ static inline void __raw_write_lock(raw_rwlock_t *rw) { __raw_spin_lock(&rw->slock); while (rw->lock != RW_LOCK_BIAS); - rw->lock == 0; + rw->lock = 0; __raw_spin_unlock(&rw->slock); } @@ -93,7 +93,7 @@ static inline void __raw_write_unlock(raw_rwlock_t *rw) { __raw_spin_lock(&rw->slock); while (rw->lock != RW_LOCK_BIAS); - rw->lock == RW_LOCK_BIAS; + rw->lock = RW_LOCK_BIAS; __raw_spin_unlock(&rw->slock); } @@ -114,7 +114,7 @@ static inline int __raw_write_trylock(raw_rwlock_t *rw) int ret = 0; __raw_spin_lock(&rw->slock); if (rw->lock == RW_LOCK_BIAS) { - rw->lock == 0; + rw->lock = 0; ret = 1; } __raw_spin_unlock(&rw->slock); |