summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Jiang <djiang@mvista.com>2009-04-21 12:24:56 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2009-04-21 13:41:51 -0700
commit55e5750b3e979bac853c0809ad0ef75b7cebd18c (patch)
tree6cb6d0576a557b7559bf7230d692609de1763bbe
parentb298cecb3deddf76d60022473a57f1cb776cbdcd (diff)
downloadlinux-3.10-55e5750b3e979bac853c0809ad0ef75b7cebd18c.tar.gz
linux-3.10-55e5750b3e979bac853c0809ad0ef75b7cebd18c.tar.bz2
linux-3.10-55e5750b3e979bac853c0809ad0ef75b7cebd18c.zip
edac: ppc mpc85xx fix mc err detect
Error found by Jeff Haran. The error detect register is 0s when no errors are detected. The check code is incorrect, so reverse check sense. Reported-by: Jeff Haran <jharan@Brocade.COM> Signed-off-by: Dave Jiang <djiang@mvista.com> Signed-off-by: Doug Thompson <dougthompson@xmission.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Acked-by: Kumar Gala <galak@kernel.crashing.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/edac/mpc85xx_edac.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 4637a4a757d..7c8c2d72916 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -674,7 +674,7 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci)
int row_index;
err_detect = in_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT);
- if (err_detect)
+ if (!err_detect)
return;
mpc85xx_mc_printk(mci, KERN_ERR, "Err Detect Register: %#8.8x\n",