diff options
| author | Steven Rostedt <srostedt@redhat.com> | 2012-12-14 13:15:08 -0500 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2013-01-21 13:22:28 -0500 |
| commit | 418c59e49ddc77fcb7054f2c8d52c9d47403b43e (patch) | |
| tree | a6ad61da008f95849076912a3485237d14ec3e46 | |
| parent | c1bf08ac26e92122faab9f6c32ea8aba94612dae (diff) | |
| download | linux-3.10-418c59e49ddc77fcb7054f2c8d52c9d47403b43e.tar.gz linux-3.10-418c59e49ddc77fcb7054f2c8d52c9d47403b43e.tar.bz2 linux-3.10-418c59e49ddc77fcb7054f2c8d52c9d47403b43e.zip | |
tracing: Fix sparse warning with is_signed_type() macro
Sparse complains when is_signed_type() is used on a pointer.
This macro is needed for the format output used for ftrace
and perf, to know if a binary field is a signed type or not.
The is_signed_type() macro is used against all fields that are
recorded by events to automate the operation.
The problem sparse has is with the current way is_signed_type()
works:
((type)-1 < 0)
If "type" is a poiner, than sparse does not like it being compared
to an integer (zero). The simple fix is to just give zero the
same type. The runtime result stays the same.
Reported-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| -rw-r--r-- | include/linux/ftrace_event.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h index a3d489531d8..43ef8b6cce7 100644 --- a/include/linux/ftrace_event.h +++ b/include/linux/ftrace_event.h @@ -272,7 +272,7 @@ extern int trace_define_field(struct ftrace_event_call *call, const char *type, extern int trace_add_event_call(struct ftrace_event_call *call); extern void trace_remove_event_call(struct ftrace_event_call *call); -#define is_signed_type(type) (((type)(-1)) < 0) +#define is_signed_type(type) (((type)(-1)) < (type)0) int trace_set_clr_event(const char *system, const char *event, int set); |