summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Piggin <npiggin@suse.de>2009-01-14 07:28:16 +0100
committerLinus Torvalds <torvalds@linux-foundation.org>2009-01-14 07:32:44 -0800
commit18e6959c385f3edf3991fa6662a53dac4eb10d5b (patch)
tree9cb7911e022ce8943bdfb3f6611ce758963abb67
parenta6525042bfdfcab128bd91fad264de10fd24a55e (diff)
downloadlinux-3.10-18e6959c385f3edf3991fa6662a53dac4eb10d5b.tar.gz
linux-3.10-18e6959c385f3edf3991fa6662a53dac4eb10d5b.tar.bz2
linux-3.10-18e6959c385f3edf3991fa6662a53dac4eb10d5b.zip
mm: fix assertion
This assertion is incorrect for lockless pagecache. By definition if we have an unpinned page that we are trying to take a speculative reference to, it may become the tail of a compound page at any time (if it is freed, then reallocated as a compound page). It was still a valid assertion for the vmscan.c LRU isolation case, but it doesn't seem incredibly helpful... if somebody wants it, they can put it back directly where it applies in the vmscan code. Signed-off-by: Nick Piggin <npiggin@suse.de> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--include/linux/mm.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/mm.h b/include/linux/mm.h
index b91a73fd1bc..e8ddc98b840 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -260,7 +260,6 @@ static inline int put_page_testzero(struct page *page)
*/
static inline int get_page_unless_zero(struct page *page)
{
- VM_BUG_ON(PageTail(page));
return atomic_inc_not_zero(&page->_count);
}