summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnton Vorontsov <avorontsov@ru.mvista.com>2008-10-06 07:26:54 +0000
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>2008-10-10 15:55:17 +1100
commit4538d0ca71b4f8991c4c0f433d7d17805738326e (patch)
tree2d7e4ea97a8a19280514375c59612d20a841c848
parent9fd3f88cb67ac51bd5face8441472b91e042be67 (diff)
downloadlinux-3.10-4538d0ca71b4f8991c4c0f433d7d17805738326e.tar.gz
linux-3.10-4538d0ca71b4f8991c4c0f433d7d17805738326e.tar.bz2
linux-3.10-4538d0ca71b4f8991c4c0f433d7d17805738326e.zip
powerpc: Fix no interrupt handling in pata_of_platform
When no interrupt is specified the pata_of_platform fills the irq_res resource with -1, which is wrong to do for two reasons: 1. By definition, 'no irq' should be IRQ 0, not some negative integer; 2. pata_platform checks for irq_res.start > 0, but since irq_res.start is unsigned type, the check will be true for `-1'. Reported-by: Steven A. Falco <sfalco@harris.com> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r--drivers/ata/pata_of_platform.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ata/pata_of_platform.c b/drivers/ata/pata_of_platform.c
index 408da30594c..1f18ad9e4fe 100644
--- a/drivers/ata/pata_of_platform.c
+++ b/drivers/ata/pata_of_platform.c
@@ -52,7 +52,7 @@ static int __devinit pata_of_platform_probe(struct of_device *ofdev,
ret = of_irq_to_resource(dn, 0, &irq_res);
if (ret == NO_IRQ)
- irq_res.start = irq_res.end = -1;
+ irq_res.start = irq_res.end = 0;
else
irq_res.flags = 0;