summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSachin Prabhu <sprabhu@redhat.com>2012-03-28 18:07:08 +0100
committerSteve French <sfrench@us.ibm.com>2012-04-03 18:04:35 -0500
commit1023807458b6365e28c66095648e1b66e04a4259 (patch)
treeafd016f0e10a8bc50f96e13b0542fe00f487a786
parent66189be74ff5f9f3fd6444315b85be210d07cef2 (diff)
downloadlinux-3.10-1023807458b6365e28c66095648e1b66e04a4259.tar.gz
linux-3.10-1023807458b6365e28c66095648e1b66e04a4259.tar.bz2
linux-3.10-1023807458b6365e28c66095648e1b66e04a4259.zip
Remove unnecessary check for NULL in password parser
The password parser has an unnecessary check for a NULL value which triggers warnings in source checking tools. The code contains artifacts from the old parsing code which are no longer required. Signed-off-by: Sachin Prabhu <sprabhu@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
-rw-r--r--fs/cifs/connect.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 302a15c505a..0511fdbdf92 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1565,8 +1565,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
/* Obtain the value string */
value = strchr(data, '=');
- if (value != NULL)
- *value++ = '\0';
+ value++;
/* Set tmp_end to end of the string */
tmp_end = (char *) value + strlen(value);