summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFrancois Romieu <romieu@fr.zoreil.com>2012-01-31 11:09:21 +0100
committerFrancois Romieu <romieu@fr.zoreil.com>2012-01-31 14:32:44 +0100
commit934714d088f35b81edafdce89397969baf77fb8a (patch)
tree48167324c0eaa5ac1a69088d0a8f95bc479aa1dc
parent6c4a70c5f286077e78b294b3f3a93dc45c40db89 (diff)
downloadlinux-3.10-934714d088f35b81edafdce89397969baf77fb8a.tar.gz
linux-3.10-934714d088f35b81edafdce89397969baf77fb8a.tar.bz2
linux-3.10-934714d088f35b81edafdce89397969baf77fb8a.zip
r8169: avoid a useless work scheduling.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com> Suggested-by: Michał Mirosław <mirqus@gmail.com> Cc: Hayes Wang <hayeswang@realtek.com>
-rw-r--r--drivers/net/ethernet/realtek/r8169.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 679711e4c3c..0377ffaa8be 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -5843,7 +5843,8 @@ static void rtl_slow_event_work(struct rtl8169_private *tp)
/* Work around for rx fifo overflow */
case RTL_GIGA_MAC_VER_11:
netif_stop_queue(dev);
- rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_PENDING);
+ /* XXX - Hack alert. See rtl_task(). */
+ set_bit(RTL_FLAG_TASK_RESET_PENDING, tp->wk.flags);
default:
break;
}
@@ -5868,6 +5869,7 @@ static void rtl_task(struct work_struct *work)
int bitnr;
void (*action)(struct rtl8169_private *);
} rtl_work[] = {
+ /* XXX - keep rtl_slow_event_work() as first element. */
{ RTL_FLAG_TASK_SLOW_PENDING, rtl_slow_event_work },
{ RTL_FLAG_TASK_RESET_PENDING, rtl_reset_work },
{ RTL_FLAG_TASK_PHY_PENDING, rtl_phy_work }