summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCloud Ren <cjren@qca.qualcomm.com>2012-07-03 16:51:48 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-09 08:31:41 -0700
commitaa505bba77961634215eb8bdd8ab9f4bd0c6f1d1 (patch)
treeddbbc0950dee37a968241c4d19071c2bd4dc268b
parentc0ce1fd51e122606d555dfd57f5c703b2af12146 (diff)
downloadlinux-3.10-aa505bba77961634215eb8bdd8ab9f4bd0c6f1d1.tar.gz
linux-3.10-aa505bba77961634215eb8bdd8ab9f4bd0c6f1d1.tar.bz2
linux-3.10-aa505bba77961634215eb8bdd8ab9f4bd0c6f1d1.zip
atl1c: fix issue of transmit queue 0 timed out
[ Upstream commit b94e52f62683dc0b00c6d1b58b80929a078c0fd5 ] some people report atl1c could cause system hang with following kernel trace info: --------------------------------------- WARNING: at.../net/sched/sch_generic.c:258 dev_watchdog+0x1db/0x1d0() ... NETDEV WATCHDOG: eth0 (atl1c): transmit queue 0 timed out ... --------------------------------------- This is caused by netif_stop_queue calling when cable Link is down. So remove netif_stop_queue, because link_watch will take it over. Signed-off-by: xiong <xiong@qca.qualcomm.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Cloud Ren <cjren@qca.qualcomm.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/net/ethernet/atheros/atl1c/atl1c_main.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 1ef0c9275de..65fe6324d81 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -267,7 +267,6 @@ static void atl1c_check_link_status(struct atl1c_adapter *adapter)
dev_warn(&pdev->dev, "stop mac failed\n");
atl1c_set_aspm(hw, false);
netif_carrier_off(netdev);
- netif_stop_queue(netdev);
atl1c_phy_reset(hw);
atl1c_phy_init(&adapter->hw);
} else {