summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Herbert <therbert@google.com>2012-11-16 09:04:15 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-11-26 11:37:47 -0800
commitf86c309e326f800e8fb028df35051aac5a26ef8d (patch)
tree363cbdc91f43c97e199f54322acd17d07c00d94d
parent4e95708469b3b36b123c9ebfe4fed2b9de601e7a (diff)
downloadlinux-3.10-f86c309e326f800e8fb028df35051aac5a26ef8d.tar.gz
linux-3.10-f86c309e326f800e8fb028df35051aac5a26ef8d.tar.bz2
linux-3.10-f86c309e326f800e8fb028df35051aac5a26ef8d.zip
net-rps: Fix brokeness causing OOO packets
[ Upstream commit baefa31db2f2b13a05d1b81bdf2d20d487f58b0a ] In commit c445477d74ab3779 which adds aRFS to the kernel, the CPU selected for RFS is not set correctly when CPU is changing. This is causing OOO packets and probably other issues. Signed-off-by: Tom Herbert <therbert@google.com> Acked-by: Eric Dumazet <edumazet@google.com> Acked-by: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--net/core/dev.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index 24a21f36a47..eb858dc6ab8 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2763,8 +2763,10 @@ static int get_rps_cpu(struct net_device *dev, struct sk_buff *skb,
if (unlikely(tcpu != next_cpu) &&
(tcpu == RPS_NO_CPU || !cpu_online(tcpu) ||
((int)(per_cpu(softnet_data, tcpu).input_queue_head -
- rflow->last_qtail)) >= 0))
+ rflow->last_qtail)) >= 0)) {
+ tcpu = next_cpu;
rflow = set_rps_cpu(dev, skb, rflow, next_cpu);
+ }
if (tcpu != RPS_NO_CPU && cpu_online(tcpu)) {
*rflowp = rflow;