summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHans-Christian Egtvedt <egtvedt@samfundet.no>2013-05-13 22:22:10 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-06-07 12:49:10 -0700
commit0690035949b0bed0ccda0b6dfb12eed942a3ff7c (patch)
tree3b04251bed5e5c90ff907bc1b74bd480945bbf85
parent6cbe92c7c20204a1f8676fb6a05432a133d58ef2 (diff)
downloadlinux-3.10-0690035949b0bed0ccda0b6dfb12eed942a3ff7c.tar.gz
linux-3.10-0690035949b0bed0ccda0b6dfb12eed942a3ff7c.tar.bz2
linux-3.10-0690035949b0bed0ccda0b6dfb12eed942a3ff7c.zip
avr32: fix relocation check for signed 18-bit offset
commit e68c636d88db3fda74e664ecb1a213ae0d50a7d8 upstream. Caught by static code analysis by David. Reported-by: David Binderman <dcb314@hotmail.com> Signed-off-by: Hans-Christian Egtvedt <egtvedt@samfundet.no> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--arch/avr32/kernel/module.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/avr32/kernel/module.c b/arch/avr32/kernel/module.c
index 596f7305d93..2c941290802 100644
--- a/arch/avr32/kernel/module.c
+++ b/arch/avr32/kernel/module.c
@@ -264,7 +264,7 @@ int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab,
break;
case R_AVR32_GOT18SW:
if ((relocation & 0xfffe0003) != 0
- && (relocation & 0xfffc0003) != 0xffff0000)
+ && (relocation & 0xfffc0000) != 0xfffc0000)
return reloc_overflow(module, "R_AVR32_GOT18SW",
relocation);
relocation >>= 2;