diff options
| author | Jan Kara <jack@suse.cz> | 2013-01-30 00:28:01 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-03-04 06:06:41 +0800 |
| commit | 0f600ee1431404eb87d36b84a66ccc004c5ace9b (patch) | |
| tree | e64b3b679a5f5ce2829a7aec3c9a483acfb05a24 | |
| parent | d48e3a8dc45d9eac3e2be330ef4df663a6f54dfc (diff) | |
| download | linux-3.10-0f600ee1431404eb87d36b84a66ccc004c5ace9b.tar.gz linux-3.10-0f600ee1431404eb87d36b84a66ccc004c5ace9b.tar.bz2 linux-3.10-0f600ee1431404eb87d36b84a66ccc004c5ace9b.zip | |
fs: Fix possible use-after-free with AIO
commit 54c807e71d5ac59dee56c685f2b66e27cd54c475 upstream.
Running AIO is pinning inode in memory using file reference. Once AIO
is completed using aio_complete(), file reference is put and inode can
be freed from memory. So we have to be sure that calling aio_complete()
is the last thing we do with the inode.
Acked-by: Jeff Moyer <jmoyer@redhat.com>
CC: Christoph Hellwig <hch@infradead.org>
CC: Jens Axboe <axboe@kernel.dk>
CC: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | fs/direct-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/direct-io.c b/fs/direct-io.c index f4aadd15b61..29c4fdab29d 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -305,9 +305,9 @@ static ssize_t dio_complete(struct dio *dio, loff_t offset, ssize_t ret, bool is dio->end_io(dio->iocb, offset, transferred, dio->private, ret, is_async); } else { + inode_dio_done(dio->inode); if (is_async) aio_complete(dio->iocb, ret, 0); - inode_dio_done(dio->inode); } return ret; |