diff options
| author | Wolfram Sang <w.sang@pengutronix.de> | 2010-02-02 13:03:31 +0100 |
|---|---|---|
| committer | Ben Dooks <ben-linux@fluff.org> | 2010-05-20 00:19:01 +0100 |
| commit | b5c80bc5d70a1ce5b071ed06dd95292b9de46f95 (patch) | |
| tree | b31d6cde6971b099e90d2fbffceb85b9f27158f6 | |
| parent | f0ec9e20bab214f4a26e6fdaaf5c2a6b2f2640d7 (diff) | |
| download | linux-3.10-b5c80bc5d70a1ce5b071ed06dd95292b9de46f95.tar.gz linux-3.10-b5c80bc5d70a1ce5b071ed06dd95292b9de46f95.tar.bz2 linux-3.10-b5c80bc5d70a1ce5b071ed06dd95292b9de46f95.zip | |
i2c-highlander: remover superflous variable
When cppcheck found this flaw
[./i2c/busses/i2c-highlander.c:284]: (style) Warning - using char variable in bit operation
it was noted that the 'read'-variable could be simply removed as read_write can
only be 0 or 1 anyhow. So, we remove the flaw and simplify the code.
Reported-by: d binderman <dcb314@hotmail.com>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: Jean Delvare <khali@linux-fr.org>
Cc: Ben Dooks <ben-linux@fluff.org>
| -rw-r--r-- | drivers/i2c/busses/i2c-highlander.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/i2c/busses/i2c-highlander.c b/drivers/i2c/busses/i2c-highlander.c index ce87a902c94..3df1bc80f37 100644 --- a/drivers/i2c/busses/i2c-highlander.c +++ b/drivers/i2c/busses/i2c-highlander.c @@ -282,7 +282,6 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr, union i2c_smbus_data *data) { struct highlander_i2c_dev *dev = i2c_get_adapdata(adap); - int read = read_write & I2C_SMBUS_READ; u16 tmp; init_completion(&dev->cmd_complete); @@ -337,11 +336,11 @@ static int highlander_i2c_smbus_xfer(struct i2c_adapter *adap, u16 addr, highlander_i2c_done(dev); /* Set slave address */ - iowrite16((addr << 1) | read, dev->base + SMSMADR); + iowrite16((addr << 1) | read_write, dev->base + SMSMADR); highlander_i2c_command(dev, command, dev->buf_len); - if (read) + if (read_write == I2C_SMBUS_READ) return highlander_i2c_read(dev); else return highlander_i2c_write(dev); |