diff options
| author | Wei Dong <weid@nanjing-fnst.com> | 2006-08-31 15:24:48 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-08-31 15:24:48 -0700 |
| commit | 0668b47205e42c04e9c1b594573be5a822ac7f09 (patch) | |
| tree | efc844d3b50e37a0db4cc650c7b005911945e786 | |
| parent | 5991c84421f3ea1e281954610a39e4993e5c39e4 (diff) | |
| download | linux-3.10-0668b47205e42c04e9c1b594573be5a822ac7f09.tar.gz linux-3.10-0668b47205e42c04e9c1b594573be5a822ac7f09.tar.bz2 linux-3.10-0668b47205e42c04e9c1b594573be5a822ac7f09.zip | |
[IPV4]: Fix SNMPv2 "ipFragFails" counter error
When I tested Linux kernel 2.6.17.7 about statistics
"ipFragFails",found that this counter couldn't increase correctly. The
criteria is RFC2011:
RFC2011
ipFragFails OBJECT-TYPE
SYNTAX Counter32
MAX-ACCESS read-only
STATUS current
DESCRIPTION
"The number of IP datagrams that have been discarded because
they needed to be fragmented at this entity but could not
be, e.g., because their Don't Fragment flag was set."
::= { ip 18 }
When I send big IP packet to a router with DF bit set to 1 which need to
be fragmented, and router just sends an ICMP error message
ICMP_FRAG_NEEDED but no increments for this counter(in the function
ip_fragment).
Signed-off-by: Wei Dong <weid@nanjing-fnst.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/ip_output.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 4c20f554689..a2ede167e04 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -440,6 +440,7 @@ int ip_fragment(struct sk_buff *skb, int (*output)(struct sk_buff*)) iph = skb->nh.iph; if (unlikely((iph->frag_off & htons(IP_DF)) && !skb->local_df)) { + IP_INC_STATS(IPSTATS_MIB_FRAGFAILS); icmp_send(skb, ICMP_DEST_UNREACH, ICMP_FRAG_NEEDED, htonl(dst_mtu(&rt->u.dst))); kfree_skb(skb); |