summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Dumazet <eric.dumazet@gmail.com>2010-09-09 05:33:43 +0000
committerDavid S. Miller <davem@davemloft.net>2010-09-09 15:02:39 -0700
commit49d61e2390c92bd226fc395a6165eb5a65ae4de6 (patch)
treed5c6e07e51999aca2a461c7087b7a01461c66ba8
parentf39234d60617d37818b30991e6794643ce220296 (diff)
downloadlinux-3.10-49d61e2390c92bd226fc395a6165eb5a65ae4de6.tar.gz
linux-3.10-49d61e2390c92bd226fc395a6165eb5a65ae4de6.tar.bz2
linux-3.10-49d61e2390c92bd226fc395a6165eb5a65ae4de6.zip
tunnels: missing rcu_assign_pointer()
xfrm4_tunnel_register() & xfrm6_tunnel_register() should use rcu_assign_pointer() to make sure previous writes (to handler->next) are committed to memory before chain insertion. deregister functions dont need a particular barrier. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/ipv4/tunnel4.c2
-rw-r--r--net/ipv6/tunnel6.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tunnel4.c b/net/ipv4/tunnel4.c
index df59d16337f..9a17bd2a0a3 100644
--- a/net/ipv4/tunnel4.c
+++ b/net/ipv4/tunnel4.c
@@ -39,7 +39,7 @@ int xfrm4_tunnel_register(struct xfrm_tunnel *handler, unsigned short family)
}
handler->next = *pprev;
- *pprev = handler;
+ rcu_assign_pointer(*pprev, handler);
ret = 0;
diff --git a/net/ipv6/tunnel6.c b/net/ipv6/tunnel6.c
index 3177fe0459e..d9864725d0c 100644
--- a/net/ipv6/tunnel6.c
+++ b/net/ipv6/tunnel6.c
@@ -51,7 +51,7 @@ int xfrm6_tunnel_register(struct xfrm6_tunnel *handler, unsigned short family)
}
handler->next = *pprev;
- *pprev = handler;
+ rcu_assign_pointer(*pprev, handler);
ret = 0;