summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Cox <alan@linux.intel.com>2012-07-25 16:28:19 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-08-15 08:10:10 -0700
commitcabf5b0af54cec6a2f9ce674cbc96fc8aa2fc468 (patch)
tree711098e955a849ef1d79acd8891b3026113d0916
parent0295403cd835f7260c6d9262817138f9f1cd8e19 (diff)
downloadlinux-3.10-cabf5b0af54cec6a2f9ce674cbc96fc8aa2fc468.tar.gz
linux-3.10-cabf5b0af54cec6a2f9ce674cbc96fc8aa2fc468.tar.bz2
linux-3.10-cabf5b0af54cec6a2f9ce674cbc96fc8aa2fc468.zip
x86, nops: Missing break resulting in incorrect selection on Intel
commit d6250a3f12edb3a86db9598ffeca3de8b4a219e9 upstream. The Intel case falls through into the generic case which then changes the values. For cases like the P6 it doesn't do the right thing so this seems to be a screwup. Signed-off-by: Alan Cox <alan@linux.intel.com> Link: http://lkml.kernel.org/n/tip-lww2uirad4skzjlmrm0vru8o@git.kernel.org Signed-off-by: H. Peter Anvin <hpa@zytor.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--arch/x86/kernel/alternative.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 1f84794f075..73ef56c5a8b 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -219,7 +219,7 @@ void __init arch_init_ideal_nops(void)
ideal_nops = intel_nops;
#endif
}
-
+ break;
default:
#ifdef CONFIG_X86_64
ideal_nops = k8_nops;