diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-03-22 15:03:54 +0300 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2010-04-30 14:52:28 -0500 |
| commit | 99fb19d49ecbeb390e023f58867c227a15f422f7 (patch) | |
| tree | 80560a57aa2b588ceaff2f65073c250c3bb317a1 | |
| parent | be1066bbcd443a65df312fdecea7e4959adedb45 (diff) | |
| download | linux-3.10-99fb19d49ecbeb390e023f58867c227a15f422f7.tar.gz linux-3.10-99fb19d49ecbeb390e023f58867c227a15f422f7.tar.bz2 linux-3.10-99fb19d49ecbeb390e023f58867c227a15f422f7.zip | |
dlm: cleanup remove unused code
Smatch complains because "lkb" is never NULL. Looking at it, the original
code actually adds the new element to the end of the list fine, so we can
just get rid of the if condition. This code is four years old and no one
has complained so it must work.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
| -rw-r--r-- | fs/dlm/lock.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index 17903b49129..031dbe3a15c 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -733,10 +733,7 @@ static void lkb_add_ordered(struct list_head *new, struct list_head *head, if (lkb->lkb_rqmode < mode) break; - if (!lkb) - list_add_tail(new, head); - else - __list_add(new, lkb->lkb_statequeue.prev, &lkb->lkb_statequeue); + __list_add(new, lkb->lkb_statequeue.prev, &lkb->lkb_statequeue); } /* add/remove lkb to rsb's grant/convert/wait queue */ |