diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2006-10-18 13:39:28 -0700 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2006-10-31 20:22:06 -0500 |
| commit | 0ca43235b34c92278fa903297acef37198ec3e26 (patch) | |
| tree | df6a9dc9ad39e7aa45abbcc7f6cb7db781c7f69b | |
| parent | 798b6b19d7a4b6e1ea5340ec8b3b92811e05b81b (diff) | |
| download | linux-3.10-0ca43235b34c92278fa903297acef37198ec3e26.tar.gz linux-3.10-0ca43235b34c92278fa903297acef37198ec3e26.tar.bz2 linux-3.10-0ca43235b34c92278fa903297acef37198ec3e26.zip | |
[PATCH] sky2: netpoll on dual port cards
The sky2 driver uses a single NAPI poll routine for both ports on dual ported
cards (because there is a single IRQ and status ring). Netpoll makes assumptions
about the relationship between network device and NAPI that aren't correct
on the second port, this will cause the port to never clear work.
Most systems, just have single port, so not a big issue.
The easy fix is just make the second port, not netpoll capable.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
| -rw-r--r-- | drivers/net/sky2.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/sky2.c b/drivers/net/sky2.c index 53171f62b26..16616f5440d 100644 --- a/drivers/net/sky2.c +++ b/drivers/net/sky2.c @@ -3238,7 +3238,11 @@ static __devinit struct net_device *sky2_init_netdev(struct sky2_hw *hw, dev->poll = sky2_poll; dev->weight = NAPI_WEIGHT; #ifdef CONFIG_NET_POLL_CONTROLLER - dev->poll_controller = sky2_netpoll; + /* Network console (only works on port 0) + * because netpoll makes assumptions about NAPI + */ + if (port == 0) + dev->poll_controller = sky2_netpoll; #endif sky2 = netdev_priv(dev); |