diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2012-09-24 14:51:48 -0400 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2012-10-02 21:35:55 -0400 |
| commit | 2bd2c1941f141ad780135ccc1cd08ca71a24f10a (patch) | |
| tree | 04246dc63002b003e67591a44c49395dcc79a70e | |
| parent | 8f9c0119d7ba94c3ad13876acc240d7f12b6d8e1 (diff) | |
| download | linux-3.10-2bd2c1941f141ad780135ccc1cd08ca71a24f10a.tar.gz linux-3.10-2bd2c1941f141ad780135ccc1cd08ca71a24f10a.tar.bz2 linux-3.10-2bd2c1941f141ad780135ccc1cd08ca71a24f10a.zip | |
MAX_LFS_FILESIZE should be a loff_t
fs/nfs/internal.h: In function ‘nfs_super_set_maxbytes’:
fs/nfs/internal.h:547:21: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
Seen with gcc (GCC) 4.6.3 20120306 (Red Hat 4.6.3-2).
Commit 42cb56ae made s_maxbytes a loff_t, thus the type of
MAX_LFS_FILESIZE should also be a loff_t.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| -rw-r--r-- | include/linux/fs.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/fs.h b/include/linux/fs.h index de1db1c1208..ca6d8c806f4 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -1130,9 +1130,9 @@ static inline int file_check_writeable(struct file *filp) /* Page cache limit. The filesystems should put that into their s_maxbytes limits, otherwise bad things can happen in VM. */ #if BITS_PER_LONG==32 -#define MAX_LFS_FILESIZE (((u64)PAGE_CACHE_SIZE << (BITS_PER_LONG-1))-1) +#define MAX_LFS_FILESIZE (((loff_t)PAGE_CACHE_SIZE << (BITS_PER_LONG-1))-1) #elif BITS_PER_LONG==64 -#define MAX_LFS_FILESIZE 0x7fffffffffffffffUL +#define MAX_LFS_FILESIZE ((loff_t)0x7fffffffffffffff) #endif #define FL_POSIX 1 |