diff options
| author | Tomas Winkler <tomas.winkler@intel.com> | 2013-04-23 07:38:12 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-04-23 10:29:58 -0700 |
| commit | 70135393812f4aa10aa891725786a7657064c2fc (patch) | |
| tree | 1cda8108939b16f7e76e6b25ef009e0f4c71a8ce | |
| parent | 0cfee51c7c1fa47d81b3d116df3b53c586aac422 (diff) | |
| download | linux-3.10-70135393812f4aa10aa891725786a7657064c2fc.tar.gz linux-3.10-70135393812f4aa10aa891725786a7657064c2fc.tar.bz2 linux-3.10-70135393812f4aa10aa891725786a7657064c2fc.zip | |
mei: reduce flow control only for completed messages
This fixes bug when only first chunk of a large message split
by hbuf_max_len is written to the hardware.
All the consequent chunks will not get a new credit.
A regression introduced by the commit
0ef319c93cebff9f82bdd0cdbb298f2dd00acda8
mei: streamline write complete flow function
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/mei/interrupt.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/drivers/misc/mei/interrupt.c b/drivers/misc/mei/interrupt.c index 74730713a8d..5ee2f07c929 100644 --- a/drivers/misc/mei/interrupt.c +++ b/drivers/misc/mei/interrupt.c @@ -356,13 +356,14 @@ static int mei_irq_thread_write_complete(struct mei_device *dev, s32 *slots, return -ENODEV; } - if (mei_cl_flow_ctrl_reduce(cl)) - return -ENODEV; cl->status = 0; cb->buf_idx += mei_hdr.length; - if (mei_hdr.msg_complete) + if (mei_hdr.msg_complete) { + if (mei_cl_flow_ctrl_reduce(cl)) + return -ENODEV; list_move_tail(&cb->list, &dev->write_waiting_list.list); + } return 0; } |