diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 10:44:19 +0200 |
|---|---|---|
| committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-08-22 18:47:25 -0700 |
| commit | fc2bc0c29a4e32da13ab75101edde030a6362d10 (patch) | |
| tree | fcf1f31ac8ce63c4935073226ed8288b4111e479 | |
| parent | d9875690d9b89a866022ff49e3fcea892345ad92 (diff) | |
| download | linux-3.10-fc2bc0c29a4e32da13ab75101edde030a6362d10.tar.gz linux-3.10-fc2bc0c29a4e32da13ab75101edde030a6362d10.tar.bz2 linux-3.10-fc2bc0c29a4e32da13ab75101edde030a6362d10.zip | |
ab8500_charger: Fix error return code
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
| -rw-r--r-- | drivers/power/ab8500_charger.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/power/ab8500_charger.c b/drivers/power/ab8500_charger.c index d4f0c98428c..c2ef94702e4 100644 --- a/drivers/power/ab8500_charger.c +++ b/drivers/power/ab8500_charger.c @@ -2614,6 +2614,7 @@ static int __devinit ab8500_charger_probe(struct platform_device *pdev) create_singlethread_workqueue("ab8500_charger_wq"); if (di->charger_wq == NULL) { dev_err(di->dev, "failed to create work queue\n"); + ret = -ENOMEM; goto free_device_info; } |