summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Huewe <huewe.external.infineon@googlemail.com>2011-03-29 11:31:25 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2011-03-29 16:45:34 (GMT)
commit1309d7afbed112f0e8e90be9af975550caa0076b (patch)
tree750110269ee7a6d977494c5fb696af109ecb0aad
parent0444d76ae64fffc7851797fc1b6ebdbb44ac504a (diff)
downloadlinux-3.10-1309d7afbed112f0e8e90be9af975550caa0076b.zip
linux-3.10-1309d7afbed112f0e8e90be9af975550caa0076b.tar.gz
linux-3.10-1309d7afbed112f0e8e90be9af975550caa0076b.tar.bz2
char/tpm: Fix unitialized usage of data buffer
This patch fixes information leakage to the userspace by initializing the data buffer to zero. Reported-by: Peter Huewe <huewe.external@infineon.com> Signed-off-by: Peter Huewe <huewe.external@infineon.com> Signed-off-by: Marcel Selhorst <m.selhorst@sirrix.com> [ Also removed the silly "* sizeof(u8)". If that isn't 1, we have way deeper problems than a simple multiplication can fix. - Linus ] Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/char/tpm/tpm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c
index 1f46f1c..7beb0e2 100644
--- a/drivers/char/tpm/tpm.c
+++ b/drivers/char/tpm/tpm.c
@@ -980,7 +980,7 @@ int tpm_open(struct inode *inode, struct file *file)
return -EBUSY;
}
- chip->data_buffer = kmalloc(TPM_BUFSIZE * sizeof(u8), GFP_KERNEL);
+ chip->data_buffer = kzalloc(TPM_BUFSIZE, GFP_KERNEL);
if (chip->data_buffer == NULL) {
clear_bit(0, &chip->is_open);
put_device(chip->dev);