diff options
| author | Dan Carpenter <error27@gmail.com> | 2009-12-23 03:27:10 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-12-26 20:24:46 -0800 |
| commit | c99a3d2e04c63a795e13c26d6f2982731e1f1ae0 (patch) | |
| tree | 2c0a8e24fe40fc6b4681fb5e3c3db18e0bbd6056 | |
| parent | 1f04493123763f5b8bc6d5de9aed0222345c052c (diff) | |
| download | linux-3.10-c99a3d2e04c63a795e13c26d6f2982731e1f1ae0.tar.gz linux-3.10-c99a3d2e04c63a795e13c26d6f2982731e1f1ae0.tar.bz2 linux-3.10-c99a3d2e04c63a795e13c26d6f2982731e1f1ae0.zip | |
bond_3ad.c avoid possible null deref
A few lines earlier we assume that best->slave could be either null or non-null so
we should check it here as well.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/bonding/bond_3ad.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index 0fb7a4964e7..822f586d72a 100644 --- a/drivers/net/bonding/bond_3ad.c +++ b/drivers/net/bonding/bond_3ad.c @@ -1580,7 +1580,7 @@ static void ad_agg_selection_logic(struct aggregator *agg) // check if any partner replys if (best->is_individual) { pr_warning("%s: Warning: No 802.3ad response from the link partner for any adapters in the bond\n", - best->slave->dev->master->name); + best->slave ? best->slave->dev->master->name : "NULL"); } best->is_active = 1; |