diff options
| author | Nick Piggin <nickpiggin@yahoo.com.au> | 2006-10-04 02:15:23 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-10-04 07:55:12 -0700 |
| commit | e80ee884ae0e3794ef2b65a18a767d502ad712ee (patch) | |
| tree | 6e5704f603d1596df930bc22f5e926cc50550102 | |
| parent | b2abacf3a2699a8020829c85c16f358ba85cecaf (diff) | |
| download | linux-3.10-e80ee884ae0e3794ef2b65a18a767d502ad712ee.tar.gz linux-3.10-e80ee884ae0e3794ef2b65a18a767d502ad712ee.tar.bz2 linux-3.10-e80ee884ae0e3794ef2b65a18a767d502ad712ee.zip | |
[PATCH] mm: micro optimise zone_watermark_ok
Having min be a signed quantity means gcc can't turn high latency divides
into shifts. There happen to be two such divides for GFP_ATOMIC (ie.
networking, ie. important) allocations, one of which depends on the other.
Fixing this makes code smaller as a bonus.
Shame on somebody (probably me).
Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | mm/page_alloc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 4f59d90b81e..b5468de4986 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -900,7 +900,8 @@ int zone_watermark_ok(struct zone *z, int order, unsigned long mark, int classzone_idx, int alloc_flags) { /* free_pages my go negative - that's OK */ - long min = mark, free_pages = z->free_pages - (1 << order) + 1; + unsigned long min = mark; + long free_pages = z->free_pages - (1 << order) + 1; int o; if (alloc_flags & ALLOC_HIGH) |