summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKarsten Wiese <fzu@wemgehoertderstaat.de>2008-03-04 14:59:55 -0800
committerThomas Gleixner <tglx@linutronix.de>2008-03-09 08:42:57 +0100
commita79017660ea4597ec489fab3b5aaf71dd776dfc7 (patch)
tree87fedadc8d003391c9ccf5d3cf0aba69fb8e443d
parent38332cb98772f5ea757e6486bed7ed0381cb5f98 (diff)
downloadlinux-3.10-a79017660ea4597ec489fab3b5aaf71dd776dfc7.tar.gz
linux-3.10-a79017660ea4597ec489fab3b5aaf71dd776dfc7.tar.bz2
linux-3.10-a79017660ea4597ec489fab3b5aaf71dd776dfc7.zip
time: don't touch an offlined CPU's ts->tick_stopped in tick_cancel_sched_timer()
Silences WARN_ONs in rcu_enter_nohz() and rcu_exit_nohz(), which appeared before caused by (repeated) calls to: $ echo 0 > /sys/devices/system/cpu/cpu1/online $ echo 1 > /sys/devices/system/cpu/cpu1/online Signed-off-by: Karsten Wiese <fzu@wemgehoertderstaat.de> Cc: johnstul@us.ibm.com Cc: Rafael Wysocki <rjw@sisk.pl> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Ingo Molnar <mingo@elte.hu> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
-rw-r--r--kernel/time/tick-sched.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 2968298f8f3..686da821d37 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -640,7 +640,7 @@ void tick_cancel_sched_timer(int cpu)
if (ts->sched_timer.base)
hrtimer_cancel(&ts->sched_timer);
- ts->tick_stopped = 0;
+
ts->nohz_mode = NOHZ_MODE_INACTIVE;
}
#endif /* HIGH_RES_TIMERS */