summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2007-01-26 00:57:01 -0800
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-01-26 13:50:59 -0800
commit3eda22d19b76b15ef3420b251bd47a0ba0127589 (patch)
tree56e33efead2809440328da65174b44eb0a8b25c6
parent524418bb8ecd3dfd2975bc0aa3c2cc7e8e081f24 (diff)
downloadlinux-3.10-3eda22d19b76b15ef3420b251bd47a0ba0127589.tar.gz
linux-3.10-3eda22d19b76b15ef3420b251bd47a0ba0127589.tar.bz2
linux-3.10-3eda22d19b76b15ef3420b251bd47a0ba0127589.zip
[PATCH] md: make 'repair' actually work for raid1
When 'repair' finds a block that is different one the various parts of the mirror. it is meant to write a chosen good version to the others. However it currently writes out the original data to each. The memcpy to make all the data the same is missing. Signed-off-by: Neil Brown <neilb@suse.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--drivers/md/raid1.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 164b25dca10..ab74d40cac9 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1266,6 +1266,11 @@ static void sync_request_write(mddev_t *mddev, r1bio_t *r1_bio)
sbio->bi_sector = r1_bio->sector +
conf->mirrors[i].rdev->data_offset;
sbio->bi_bdev = conf->mirrors[i].rdev->bdev;
+ for (j = 0; j < vcnt ; j++)
+ memcpy(page_address(sbio->bi_io_vec[j].bv_page),
+ page_address(pbio->bi_io_vec[j].bv_page),
+ PAGE_SIZE);
+
}
}
}