summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Kropelin <akropel1@rochester.rr.com>2005-09-17 02:28:17 (GMT)
committerLinus Torvalds <torvalds@g5.osdl.org>2005-09-17 18:50:03 (GMT)
commitd648daca1170945600756b31866d0362a67f2aae (patch)
treec86b5735d82389efc7b91609b79c5ea5085b05e4
parentef0f6a437f92fbd96c725086555b37b29371e107 (diff)
downloadlinux-3.10-d648daca1170945600756b31866d0362a67f2aae.zip
linux-3.10-d648daca1170945600756b31866d0362a67f2aae.tar.gz
linux-3.10-d648daca1170945600756b31866d0362a67f2aae.tar.bz2
[PATCH] ibmphp: Use dword accessors for PCI_ROM_ADDRESS
PCI_ROM_ADDRESS is a 32 bit register and as such should be accessed using pci_bus_{read,write}_config_dword(). A recent audit of drivers/ turned up several cases of byte- and word-sized accesses. The harmful ones were fixed by Linus directly. This patches up one of the remaining harmless-but-still-wrong cases caught in the dragnet. Signed-off-by: Adam Kropelin <akropel1@rochester.rr.com> Cc: Greg KH <greg@kroah.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r--drivers/pci/hotplug/ibmphp_pci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c
index 8122fe7..b1ba429 100644
--- a/drivers/pci/hotplug/ibmphp_pci.c
+++ b/drivers/pci/hotplug/ibmphp_pci.c
@@ -558,7 +558,7 @@ static int configure_device (struct pci_func *func)
pci_bus_write_config_byte (ibmphp_pci_bus, devfn, PCI_CACHE_LINE_SIZE, CACHE);
pci_bus_write_config_byte (ibmphp_pci_bus, devfn, PCI_LATENCY_TIMER, LATENCY);
- pci_bus_write_config_word (ibmphp_pci_bus, devfn, PCI_ROM_ADDRESS, 0x00L);
+ pci_bus_write_config_dword (ibmphp_pci_bus, devfn, PCI_ROM_ADDRESS, 0x00L);
pci_bus_write_config_word (ibmphp_pci_bus, devfn, PCI_COMMAND, DEVICEENABLE);
return 0;