summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Jones <davej@redhat.com>2013-04-23 12:34:03 -0400
committerIngo Molnar <mingo@kernel.org>2013-04-26 08:36:33 +0200
commit199e371f59d31c828345b0d959d27d752827b517 (patch)
tree55d482c51276d98e2bcefba0b8460b48174f3e77
parentcc189d2513d1f45cde87a9043fe3be28559c7490 (diff)
downloadlinux-3.10-199e371f59d31c828345b0d959d27d752827b517.tar.gz
linux-3.10-199e371f59d31c828345b0d959d27d752827b517.tar.bz2
linux-3.10-199e371f59d31c828345b0d959d27d752827b517.zip
lockdep: Print out additional debugging advice when we hit lockdep BUGs
We occasionally get reports of these BUGs being hit, and the stack trace doesn't necessarily always tell us what we need to know about why we are hitting those limits. If users start attaching /proc/lock_stats to reports we may have more of a clue what's going on. Signed-off-by: Dave Jones <davej@redhat.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20130423163403.GA12839@redhat.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
-rw-r--r--kernel/lockdep.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index e5deddadeab..c5d1e6bbdb3 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -411,6 +411,7 @@ static int save_trace(struct stack_trace *trace)
printk("BUG: MAX_STACK_TRACE_ENTRIES too low!\n");
printk("turning off the locking correctness validator.\n");
+ printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return 0;
@@ -765,6 +766,7 @@ register_lock_class(struct lockdep_map *lock, unsigned int subclass, int force)
printk("BUG: MAX_LOCKDEP_KEYS too low!\n");
printk("turning off the locking correctness validator.\n");
+ printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return NULL;
}
@@ -836,6 +838,7 @@ static struct lock_list *alloc_list_entry(void)
printk("BUG: MAX_LOCKDEP_ENTRIES too low!\n");
printk("turning off the locking correctness validator.\n");
+ printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return NULL;
}
@@ -2050,6 +2053,7 @@ cache_hit:
printk("BUG: MAX_LOCKDEP_CHAINS too low!\n");
printk("turning off the locking correctness validator.\n");
+ printk("Attach output of /proc/lock_stat to bug report\n");
dump_stack();
return 0;
}
@@ -3191,6 +3195,7 @@ static int __lock_acquire(struct lockdep_map *lock, unsigned int subclass,
printk("BUG: MAX_LOCK_DEPTH too low, depth: %i max: %lu!\n",
curr->lockdep_depth, MAX_LOCK_DEPTH);
printk("turning off the locking correctness validator.\n");
+ printk("Attach output of /proc/lock_stat to bug report\n");
lockdep_print_held_locks(current);
debug_show_all_locks();